Ticket #493 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Rebuild/Stop html forms need method as POST

Reported by: ipv6guru Owned by: dustin
Priority: major Milestone: 0.7.11
Version: 0.7.10 Keywords: sourceforge 1679411
Cc:

Description

The Waterfall has a Stop and Rebuild properties to stop a current active build or to rebuild one that previously ran. Well since no method on the Stop or Rebuild form is specified, the Webserver does a Get which displays the information in the URI as opposed to the form data. According to HTTP, a method of POST should be used for state transitions. Which seems to be the case for Stopping a build. And to keep it concise, I think buildbot should do the same for Rebuilds.

I am attaching a patch for buildbot-0.7.5 for this problem.

Submitted: Minesh Patel ( mpatel20 ) - 2007-03-13 08:28

Attachments

buildbot-0.7.5.form.patch Download (1.3 KB) - added by ipv6guru 4 years ago.

Change History

Changed 4 years ago by ipv6guru

comment:1 Changed 4 years ago by ipv6guru

Moved from sourceforge

comment:2 Changed 4 years ago by dustin

  • Owner set to dustin
  • Status changed from new to assigned
  • Milestone changed from undecided to 0.7.11

comment:3 Changed 4 years ago by dustin

  • Status changed from assigned to closed
  • Resolution set to fixed

Things have changed a lot since 0.7.5, but I fixed the last instance of method="get" I could find in [c4de4851668847e9235a363f706a2634489e6f28].

Note: See TracTickets for help on using tickets.