Ticket #493 (closed defect: fixed)
Rebuild/Stop html forms need method as POST
|Reported by:||ipv6guru||Owned by:||dustin|
The Waterfall has a Stop and Rebuild properties to stop a current active build or to rebuild one that previously ran. Well since no method on the Stop or Rebuild form is specified, the Webserver does a Get which displays the information in the URI as opposed to the form data. According to HTTP, a method of POST should be used for state transitions. Which seems to be the case for Stopping a build. And to keep it concise, I think buildbot should do the same for Rebuilds.
I am attaching a patch for buildbot-0.7.5 for this problem.
Submitted: Minesh Patel ( mpatel20 ) - 2007-03-13 08:28
- Owner set to dustin
- Status changed from new to assigned
- Milestone changed from undecided to 0.7.11