Ticket #488 (closed defect: fixed)
svnversion results not parsed correctly
|Reported by:||ipv6guru||Owned by:|
Description (last modified by dustin) (diff)
In slave.commands.SVN.parseGotRevsion, the code assumes that the command 'svnversion' only returns an integer revision. This is incorrect, 'svnversion' may return a simple revision number, a number appended with a letter code, a pair of numbers (for a mixed revision), or a pair of numbers with an appended letter.
Getting this correct is especially important in the case where a build process may create or modify files. Then, after subsequent updates, the revision will be appended with an 'M'.
I've done a partial fix for our local buildbot installation, but a full parsing of the svnversion results should be included.
Please see the svnversion documentation for the possible outputs that can be had from svnversion.
-- Colin (colin.smith -at- acceleware.com)
Submitted: Nobody/Anonymous? ( nobody ) - 2007-08-28 00:27