Ticket #473 (closed defect: wontfix)

Opened 4 years ago

Last modified 3 years ago

Allow web-based commenting on builds

Reported by: ipv6guru Owned by:
Priority: major Milestone: 0.8.+
Version: 0.7.10 Keywords: sourceforge 1575715
Cc:

Description

This is my initial patch for the Build Commenting feature request ( http://sourceforge.net/tracker/index.php?func=detail&aid=1573390&group_id= 73177&atid=537004)

A StatusResourceComments? has been added to deal with adding comments. Existing comments are displayed on the Build page (builder/build/NN). If a build has comments and the 'starPath' parameter to Waterfall has been specified that icon will show up beside 'Build NN' on the Waterfall page. A default icon has been included.

There are a couple of things in this patch that are questionable in my mind but I could see no other way of doing it. 1) I've added a new Waterfall parameters, 'starPath'. I donn't really want to have the starPath configurable. I don't have any clue how to include this as part of the install process though, or how to actually use it since the full path would not be known. 2) StatusResourceComments?.addComment() calls saveYourself() for the paticular build it's working on. When I first attempted this I got tracebacks because things were being deleted in the getstate methods of some I*Status objects. I've put try/catch statements around all of these to get around that problem. I don't know if this is the best way to do it.

Attached is the patch itself and orangestar.png, the icon I intend to be the default.

Attachments

commentsWithoutStarPath.diff Download (14.5 KB) - added by ipv6guru 4 years ago.

Change History

Changed 4 years ago by ipv6guru

comment:1 Changed 4 years ago by ipv6guru

Moved from sourceforge

comment:2 Changed 4 years ago by dustin

  • Milestone changed from undecided to 0.7.+

Hmm, sounds like a cool idea, but I'm not sure the implementation is stable..

comment:3 Changed 4 years ago by dustin

  • Summary changed from Build Commenting patch to Allow web-based commenting on builds

comment:4 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to wontfix

I don't like the idea of commenting on builds via the web status.

Note: See TracTickets for help on using tickets.