Upgraded from 0.7.9 to 0.7.10p1 - now buildbotcheckconfig fails

[ipv6guru]

I just upgraded from 0.7.9 to 0.7.10p1 by doing

download new version
cd to new version
python sertup.py build
python setup.py install
ran the tests worked fine

That is all I did, I did not run upgrade-master.

restarted buildbot and all seems to work ok, except :-

buildbot checkconfig always gives me an error now

$ buildbot checkconfig ~buildmaster/master1 Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/buildbot/scripts/runner.py", line 908, in doCheckConfig
    ConfigLoader(configFile)
  File "/usr/lib/python2.5/site-packages/buildbot/scripts/checkconfig.py",
line 18, in __init__
    copy(configFileName, tempdir)
  File "/usr/lib/python2.5/shutil.py", line 80, in copy
    copyfile(src, dst)
  File "/usr/lib/python2.5/shutil.py", line 46, in copyfile
    fsrc = open(src, 'rb')
IOError: [Errno 21] Is a directory

I've performed the upgrade on 2 machines with the same results.

[dustin]

This looks like a documentation-reading problem. checkconfig takes the filename of a config file, rather than a buildbot base directory. However, it should support both..

[dustin]

commit 176ee2f9bd8e477cf559fdf29f8e094b94f488bf
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date:   Mon Mar 30 21:03:42 2009 -0400

    (refs #463) checkconfig should take either a dir or a config file

[ipv6guru]

Your right, doing 'buildbot checkconfig master.cfg' does work. What got me was that my 'wrong' method of just specifying the directory worked fine in 0.7.9.

Anyway, all good, thanks!

Gav...