Error with SVNPoller and Nightly scheduler using "onlyIfChanged" flag

[Philcornet]

Errors I get in my configuration:

2009/03/18 12:54 Romance Standard Time [-] SVNPoller failed
2009/03/18 12:54 Romance Standard Time [-] _finished : [Failure instance: Traceback: exceptions.TypeError: int argument required
	C:Python24libsite-packages	wistedinternetdefer.py:294:_startRunCallbacks
	C:Python24libsite-packages	wistedinternetdefer.py:307:_runCallbacks
	C:Python24libsite-packages	wistedinternetdefer.py:271:_continue
	C:Python24libsite-packages	wistedinternetdefer.py:267:unpause
	--- <exception caught here> ---
	C:Python24libsite-packages	wistedinternetdefer.py:307:_runCallbacks
	C:Python24libsite-packagesuildbotchangessvnpoller.py:452:submit_changes
	C:python24Libsite-packagesuildbotchangeschanges.py:224:addChange
	C:python24Libsite-packagesuildbotmaster.py:926:addChange
	C:Python24libsite-packagesuildbotscheduler.py:603:addChange
	]

I fixed it in Nightly::addChange by replacing the %d by a %s in the following line:

log.msg("Nightly Scheduler <%s>: ignoring change %d on off-branch %s" % (self.name, change.revision, change.branch))

Sincerly,

Philippe Cornet

[dustin]

I'll get this committed this afternoon

[dustin]

Fixed a while back in [84ee95a47f56fdd4eb5b4348bb724bf5ec5f1f43]

commit 84ee95a47f56fdd4eb5b4348bb724bf5ec5f1f43
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date:   Sat May 2 19:49:13 2009 -0400

    don't assume change.revision is an integer in buildbot/scheduler.py (thanks to Darragh Bailey and Andrew Lawrence)