Ticket #46 (closed enhancement: duplicate)

Opened 6 years ago

Last modified 3 years ago

Link the changes to the version control display

Reported by: grisha Owned by:
Priority: major Milestone: 0.8.1
Version: 0.7.5 Keywords:
Cc: Pike, joduinn

Description

It may be useful to have the changes that are displayed in the waterfall not just list the files, but actually link, if possible, to the appropriate version control page. For instance, Trac would have a changeset page for a change that is very informative.

Attachments

change.patch Download (1.6 KB) - added by soundgeek 6 years ago.
Patch to add "link" init argument.

Change History

comment:1 Changed 6 years ago by Pike

  • Cc Pike added

Yes. This might depend on the source-specific Change classes ticket, those could forward that information back, from in our case, bonsai.

comment:2 in reply to: ↑ description ; follow-up: ↓ 3 Changed 6 years ago by soundgeek

Replying to grisha: I added this functionality to buildbot/changes/changes.py by adding a "link" initialization parameter. My custom change source creates Change objects with this link and the link goes from the Build html directly to my "timeline" viewing system. I attached the patch (applied against the 0.7.5 release).

Changed 6 years ago by soundgeek

Patch to add "link" init argument.

comment:3 in reply to: ↑ 2 Changed 6 years ago by soundgeek

Oops, make that a "changelink" argument.

comment:4 Changed 6 years ago by warner

  • Owner warner deleted
  • component changed from statusplugins to statusplugins-web

comment:5 Changed 6 years ago by warner

  • Milestone set to 0.7.7

comment:6 Changed 6 years ago by joduinn

  • Cc joduinn added

comment:7 Changed 5 years ago by warner

  • Milestone changed from 0.7.7 to 0.7.8

I haven't made enough progress on this yet, bumping to 0.7.8.

comment:8 Changed 5 years ago by bhearsum

  • Cc bhearsum@… added

comment:9 Changed 4 years ago by dustin

  • Milestone changed from 0.8.0 to 1.0.+

the 1.0 web interface should be flexible enough to support this.

comment:10 Changed 4 years ago by bhearsum

  • Cc bhearsum@… removed

comment:11 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to duplicate
  • Milestone changed from 1.0.+ to 0.8.1

I think that this partially answers #836, so dupe'd there.

Note: See TracTickets for help on using tickets.