Ticket #453 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

darcs_buildbot.py and buildbot/slave/commands.py have different ideas about "revision"

Reported by: zooko Owned by: zooko@…
Priority: major Milestone: 0.7.11
Version: 0.7.10 Keywords: darcs
Cc:

Description

contrib/darcs_buildbot.py@483#L36 sets .revision to be the hash of the most recent patch. buildbot/slave/commands.py@467#L1568 interprets .revision as "context". I think this means that if a build was triggered by darcs_buildbot.py, and then someone pushes the "Rebuild" button, they'll get a completely different thing, but I haven't tested this theory.

Probably darcs_buildbot.py should be changed to execute darcs changes --context and use the resulting stdout instead of using the hash of the most recent patch.

Change History

comment:1 Changed 3 years ago by ashcrow

  • Milestone changed from undecided to 0.7.11

comment:2 Changed 3 years ago by dustin

  • Keywords darcs, sprint added; darcs removed

comment:3 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed 
commit d0bd9feb2645fa26ef9a53539aa3af7e1d5f4509
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date:   Mon Mar 30 21:42:51 2009 -0400

    (refs #453) send a revision only for the last change from
    darcs_buildbot.py, but put it in the right format

comment:4 Changed 3 years ago by dustin

  • Keywords darcs added; darcs, sprint removed
Note: See TracTickets for help on using tickets.