Opened 12 years ago

Closed 12 years ago

#435 closed defect (fixed)

step_status.setColor is used by lots of custom steps

Reported by: dustin Owned by:
Priority: major Milestone: 0.7.10
Version: 0.7.9 Keywords:
Cc: Pike

Description

Axel wrote to the list to point out that this method, which was removed in #251, is used by a lot of custom steps. The discussion is whether to leave it undefined (forcing custom step authors to recode their steps on upgrade) or just make it a logging no-op (which may lead to some "hey, setColor doesn't work anymore!" bugs).

Change History (2)

comment:1 Changed 12 years ago by Pike

  • Cc Pike added

I think that most steps just do what used to be required and setColor to what is now set via the classes, so it will probably not even look different.

I'm not sure if a noop or a log.msg() is better, I wonder how many folks are actually going to read through the log as long as it doesn't error.

I'm not sure when calling into setColor was actually required, or whether that being all over the place is just copy'n'paste.

comment:2 Changed 12 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

Fair enough!

commit cc9abfe46e718a3f91fec51c7091c8698f6f41bf
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date:   Wed Feb 25 13:10:39 2009 -0500

    (fixes #435) stub out BuildStepStatus.setColor
Note: See TracTickets for help on using tickets.