Ticket #420 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

slash not escaped in url links when builder name contains slash inside

Reported by: arekm Owned by: djmitche
Priority: minor Milestone: 0.7.10
Version: 0.7.9 Keywords: review
Cc: arekm

Description

When using builder names with slash inside like

builderNames=PLD/Linux Th?

then web interface contains links "/builders/PLD/Linux%20Th/builds/101" where the correct link should be "/builders/PLD%2fLinux%20Th/builds/101" (note slash escaped with %2f)

Change History

comment:1 Changed 4 years ago by dustin

  • Milestone changed from undecided to 0.7.10

comment:2 Changed 4 years ago by nhemingway

  • Cc arekm added
  • Keywords review added
  • Owner set to djmitche

I think I found most of them. Resolved by  http://github.com/nhemingway/buildbot/commit/71c309759447f7619779080c5848542e7c76e9af

comment:3 Changed 4 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

Great - thanks! 

commit 5bd3d78c613ac9fff056e7e2c12783fc1fe9bd82
Merge: 6dab63a... 71c3097...
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date:   Sun Feb 22 08:53:09 2009 -0500

    Merge branch 'bug420' of git://github.com/nhemingway/buildbot
Note: See TracTickets for help on using tickets.