[patch] Test_vc.py fails on windows if there are spaces in path to vc-exes

[marcusl]

This is because many test suites use a single string as argument, relying on the auto-split feature, rather than providing a list or tuple of arguments.

Darcs is a notable exception, as it behaves nicely.

I'll see if I can patch cvs, svn and hg. (The latter being the most interesting as I need to get in-repo branch to work.)

[marcusl]

Patch for CVS & SVN tests that use lists instead of spaces to separate commands

[marcusl]

The attached patch seems to work, but I have some similar problems with the actual buildbot steps (all CVS ops fail and the SVN patch does not apply cleanly), so the tests do run, but not completely on Windows.

Nevertheless, if they maintain status quo on *nix, it's still an improvement.

[marcusl]

Split string command separately from vc-exe path

[marcusl]

Mercurial string -> list patch (needs the spaces.patch)

[marcusl]

I should've named the filed .diff instead, so that they are properly viewable from Trac. I'll upload a comibined diff for all three patches.

[marcusl]

Fixed space-in-vc-exe-path issue for SVN, HG & CVS + possibly everything else

[marcusl]

Argh. I tried to cleanup the diff and upload a new one, but hit Enter before I could click the 'replace existing file' button. And apparently there was something wrong with that file as it doesn't show in Trac.

I hope you'll be able to make sense of the mess anyway.

[marcusl]

I noticed a minor typo in my patch:

-w = self.dovc(tmp, ['commit', '-m' 'commit_on_branch'])
+w = self.dovc(tmp, ['commit', '-m', 'commit_on_branch'])

[marcusl]

 http://github.com/marcusl/buildbot/tree/bug187 contains a fix of this, combined with a fix for #187.

[marcusl]

Isolated changes to  http://github.com/marcusl/buildbot/tree/bug398 instead. This also contains the additional fixes for svn, cvs and hg in the attached patches (in addition to the small change in test_vc.py that I had in the  bug187 branch.

[dustin]

commit merged - thanks!