Ticket #397 (closed defect: worksforme)

Opened 4 years ago

Last modified 3 years ago

mercurial hgbuildbot has issue with installing signal handlers

Reported by: xyld Owned by:
Priority: minor Milestone: 0.8.+
Version: 0.7.9 Keywords: hg
Cc:

Description 

Traceback (most recent call last):
  File "/home/dlamotte/portage/linux-64/usr/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/internet/base.py", line 374, in fireEvent
    DeferredList(beforeResults).addCallback(self._continueFiring)
  File "/home/dlamotte/portage/linux-64/usr/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/internet/defer.py", line 195, in addCallba
ck
    callbackKeywords=kw)
  File "/home/dlamotte/portage/linux-64/usr/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/internet/defer.py", line 186, in addCallba
cks
    self._runCallbacks()
  File "/home/dlamotte/portage/linux-64/usr/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/internet/defer.py", line 328, in _runCallb
acks
    self.result = callback(self.result, *args, **kw)
--- <exception caught here> ---
  File "/home/dlamotte/portage/linux-64/usr/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/internet/base.py", line 387, in _continueF
iring
    callable(*args, **kwargs)
  File "/home/dlamotte/portage/linux-64/usr/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/internet/base.py", line 1002, in _handleSi
gnals
    signal.signal(signal.SIGTERM, self.sigTerm)

A fix would be to turn off twisted install of signal handlers. 

--- buildbot-0.7.9.orig/buildbot/clients/sendchange.py  2008-09-16 11:02:25.000000000 -0500
+++ buildbot-0.7.9/buildbot/clients/sendchange.py       2008-12-07 17:43:06.265968000 -0600
@@ -45,4 +45,4 @@
         return res
 
     def run(self):
-        reactor.run()
+        reactor.run(installSignalHandlers=False)

Change History

comment:1 Changed 4 years ago by dustin

  • Milestone changed from undecided to 0.7.+

What's the exception? I only see filenames in the traceback you pasted.

comment:2 Changed 3 years ago by dustin

  • Keywords mercurial signal removed
  • Status changed from new to closed
  • Resolution set to worksforme

Can't fix it without seeing the full traceback..

Note: See TracTickets for help on using tickets.