Opened 10 years ago

Last modified 5 years ago

#394 new enhancement

I want buildbot to repeatedly notify the person responsible for the build break that the build is still broken, so that they know when it is fixed.

Reported by: mmacvicar Owned by:
Priority: major Milestone: 2.0.+
Version: 0.7.9 Keywords: mail
Cc:

Description

I want buildbot to repeatedly notify the person responsible for the build break that the build is still broken, so that they know when it is fixed.

Right now the blamelist is a list of users responsible for the current build, but it would be useful to track the users responsible for breaking the build. I'd like to be able to send a notification that the build is still broken the the responsible user either every build or each time they trigger another build.

For example:

User A checks in and breaks the build and is notified. User B checks in and the build is still broken (no notification since they didn't break it). User A checks in a potential fix and the build is still broken (it would be nice to be able to notify User A that the build is still broken) User A checks in and fixes the build (no notification, everything is happy).

Change History (8)

comment:1 Changed 10 years ago by dustin

  • Milestone changed from undecided to 0.7.+

comment:2 Changed 9 years ago by tfogal

We've got a similar system in a home-brewed discontinuous integration system for one project I work on.

I'm not sure if failing to notify user B is all that useful. For one, it won't happen often; user B can't effectively test their work in many cases, so they probably won't be committing anyway. Secondly, user B might fix A's bug but cause their own failure. Finally, it's not really all that disruptive to notify B anyway; a broken build is bad for a project *globally*, not just for one user.

So I think this could be solved 'simply' by making blamelists persistent. Store them between runs. Union blamelists when builds fail. Nullify them when a build succeeds. I guess that's really more of a "blameset".

comment:3 Changed 9 years ago by dustin

Honestly, I don't understand this idea of only notifying the blamelist. Personally, I find notification of anyone else's breakage just as useful, if not more useful, as notification of my own breakage. So I suspect that this is an area where we will need to introduce a few different notifier classes, once we have an easily-queryable status system.

comment:4 Changed 8 years ago by dustin

  • Keywords status notification removed

comment:5 Changed 8 years ago by maruel

I think this ticket should be closed as WontFix?. If you want to have people be notified, be sure to cc the whole team mailing list so email threading correctly occurs, assuming you use a email client supporting email threads.

A good workaround is to close the tree on build failure and not let other people commit until the failure is resolved.

I'll let Dustin close the issue if he thinks it's a good idea.

comment:6 Changed 8 years ago by dustin

  • Milestone changed from 0.8.+ to 1.0.+

I agree, but this bug provides a nice aggregator for people who are interested in related kinds of functionality, so while it's not under active development, I'm happy to keep it open as "something to think about".

comment:7 Changed 8 years ago by dustin

  • Keywords mail added

comment:8 Changed 5 years ago by dcoshea

This feature would be useful for those of us who have Buildbot not just running the same "build" that all developers run prior to commit, but also running lengthy tests that take too long for every developer to run prior to to commit. In this case, failure of those tests isn't going to make you want to close the tree, and most developers won't actually be impacted by the test failure and hence won't want an email about it.

Note: See TracTickets for help on using tickets.