SKIPPED buildsteps don't get data set

[mmacvicar]

SKIPPED buildsteps don't get data set

I was experimenting with conditional buildsteps using SKIPPED, and I discovered that if you skip a step there is no start or end time for the step which can cause problems on the waterfall. Steps that are SKIPPED show up blank on the waterfall and if they are the last step of a sequence, they appear to run forever.

I'd like to see the "STEPNAME skipped" on the waterfall and have a start/end time for the step.

for example I created a variant of FileUpload? that only runs if the previous step is a failure (in order to archive the failure files)

class FileUploadOnFail(FileUpload):

    def start(self):

       previousResult = self.build.results[-1]
       # if the previous step succeeded, don't upload
       log.msg("SUCCESS=%s and previousResult=%s" % (SUCCESS, previousResult))
       if previousResult == SUCCESS: # or WARNINGS:
           return SKIPPED
       # otherwise, do what we would normally do
       FileUpload.start(self)

[dustin]

commit 5fc70886bef753aae96dbfa065e481017ee9b82a
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date:   Wed Feb 25 12:55:30 2009 -0500

    (refs #390) properly handle a return value of SKIPPED from step.start()