reconfig reports incorrect changes between locks

[darraghbailey]

When performing a reconfig after updating the locks being used to include a new lock the following was the output into the log file and onto the screen.

locks changed from [(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3_serverbuilds'),
 (<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3')] to 
[(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3')]

It should read

locks changed from [(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3')] to 
[(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3_serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3')]

Since I was adding the new lock machine3_serverbuilds, not removing it.

[darraghbailey]

patch to print the correct order

[darraghbailey]

I haven't tested the patch, but looking at the preceeding code I believed it was safe to assume that the new settings come from setup and the old from self.

[dustin]

commit 966747f09029f8bbc267cff5e9b35d3853de855a
Author: Darragh Bailey <dbailey@hp.com>
Date:   Tue Feb 3 15:10:13 2009 -0500

    (fixes #39) patch to print the correct order