Opened 11 years ago

Closed 11 years ago

#388 closed defect (fixed)

when a status plugin throws an exception in buildStarted the Build does not start, is not killable, and the slave is tied up until the master or slave is restarted

Reported by: bhearsum Owned by: djmitche
Priority: major Milestone: 0.7.10
Version: 0.7.9 Keywords: review
Cc:

Description

When we upgraded to Buildbot 0.7.9 we had a status plugin break because of the new properties interface. This uncovered the bug described in the summary. I suspect Buildbot should be calling the watchers inside of a try/except block here: http://buildbot.net/trac/browser/buildbot/status/builder.py#L1677. Status plugins should probably be responsible for catching their own exceptions, but even if one goes haywire it shouldn't cause such breakage all over the place, IMHO.

Change History (4)

comment:1 Changed 11 years ago by dustin

  • Milestone changed from undecided to 0.7.10

fair enough..

comment:2 Changed 11 years ago by nhemingway

  • Owner set to nhemingway
  • Status changed from new to assigned

comment:3 Changed 11 years ago by nhemingway

  • Keywords review added
  • Owner changed from nhemingway to djmitche
  • Status changed from assigned to new

comment:4 Changed 11 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed
commit c42b681aad38bed2ae7ae952c5a465a9f70c62bf
Merge: 4ae3012... 436c2a6...
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date:   Mon Feb 23 16:57:21 2009 -0500

    Merge branch 'bug388' of git://github.com/nhemingway/buildbot
Note: See TracTickets for help on using tickets.