exceptions.TypeError: buildFinished() takes exactly 4 arguments (2 given)

[edwin]

I get this exception when a build finishes successfully, and I don't get notified from the IRCbot:

2008-11-14 11:25:50+0200 [-] <Build quick-linux-x86_64>: build finished 2008-11-14 11:25:50+0200 [-] Unhandled error in Deferred: 2008-11-14 11:25:50+0200 [-] Unhandled Error

Traceback (most recent call last):

File "/usr/lib/python2.5/site-packages/buildbot/process/base.py", line 583, in buildFinished

self.build_status.buildFinished()

File "/usr/lib/python2.5/site-packages/buildbot/status/builder.py", line 1174, in buildFinished

w.callback(self)

File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py", line 243, in callback

self._startRunCallbacks(result)

File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py", line 312, in _startRunCallbacks

self._runCallbacks()

--- <exception caught here> ---

File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py", line 328, in _runCallbacks

self.result = callback(self.result, *args, kw)

exceptions.TypeError?: buildFinished() takes exactly 4 arguments (2 given)

2008-11-14 11:25:50+0200 [-] setting expectations for next time

Status listeners in master.cfg: cstatus?.append(html.WebStatus?(http_port=8010)) from buildbot.status.mail import MailNotifier? mn = MailNotifier?(fromaddr="buildbot@localhost",

mode = "problem", lookup="......", extraRecipients=.......?, addLogs=True)

cstatus?.append(mn) from buildbot.status import words irc = words.IRC("irc.freenode.net",".....",password=".......",

channels=.....?)

cstatus?.append(irc)

I do get mail notifications of failures though. I am using version 0.7.9-1.

[seb]

I see that too with 0.7.8

[dafire]

looks like changing

d.addCallback(self.parent.buildFinished)

to

d.addCallback(self.parent.watchedBuildFinished)

in file words.py in class IrcBuildRequest? fixes the problem.

[seb]

It does indeed fix the problem for me on 0.7.8.

[nhemingway]

Resolved by  http://github.com/nhemingway/buildbot/commit/22d65688c56f97f48106ccf9e8ba9fb210480c33

[dustin]

merged - thanks!