Ticket #381 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

successToFailed and failedToSuccess do not work with IRC

Reported by: dannyb Owned by: nhemingway
Priority: major Milestone: 0.7.10
Version: 0.7.9 Keywords:
Cc:

Description

The regexp used to check the notify arguments does not include successToFailed and failedToSuccess even though the help lists it as a valid event.

Adding it to the validation regexp fixes this. Also,

if (self.notify_for('failureToSuccess') and prevResult == FAILURE and results == SUCCESS) or

(self.notify_for('successToFailure') and prevResult == SUCCESS and results == FAILURE):

should be

if (self.notify_for('failedToSuccess') and prevResult == FAILURE and results == SUCCESS) or

(self.notify_for('successToFailed') and prevResult == SUCCESS and results == FAILURE):

(ie s/ure/ed/)

Change History

comment:1 Changed 4 years ago by nhemingway

  • Owner set to nhemingway
  • Status changed from new to assigned

comment:2 Changed 4 years ago by nhemingway

  • Keywords review added

Resolved by  http://github.com/nhemingway/buildbot/commit/7c2ee0b490e602a7c5518e14456829612f952b5b. I have standardized on successToFailed and failedToSuccess

comment:3 Changed 4 years ago by dustin

  • Keywords review removed
  • Status changed from assigned to closed
  • Resolution set to fixed

committed

comment:4 Changed 4 years ago by dustin

  • Milestone changed from undecided to 0.7.10
Note: See TracTickets for help on using tickets.