force'd builds from irc don't shout unless specific event happens

[dannyb]

Forced builds from irc create an ircbuildrequest that calls parent.buildFinished when done.

buildFinished has this code:

if not self.notify_for('finished', 'failed', 'success', 'exception', 'failedToSuccess', 'successToFailed'):

return

Thus, if you don't have a specific notify set, a forced irc build will never tell you when it is finished.

This is a regression from previous versions.

The easiest way to fix it is to change IRCBuildRequest to do:

d.addCallback(self.parent.watchedBuildFinished)

instead of

d.addCallback(self.parent.buildFinished)

This causes it to shout no matter what.

[thijs]

Thanks dannyb, that patch worked for  us using 0.7.9!

[dustin]

Neil, do you mind taking a look at this? I think it was your patch that introduced this change.

[nhemingway]

Resolved by  http://github.com/nhemingway/buildbot/commit/22d65688c56f97f48106ccf9e8ba9fb210480c33

[dustin]

merged - thanks!