Opened 4 years ago

Last modified 4 years ago

#3644 new defect

Does not collaps build requests

Reported by: kayhayen Owned by:
Priority: major Milestone: undecided
Version: 0.9.1 Keywords:
Cc:

Description

Following this documentation, I had put this into my configuration: http://docs.buildbot.net/latest/manual/cfg-global.html

c["collapseRequests"] = True

However, it is no longer working. Build requests are not collapsed anymore. I am relatively sure it was working with 0.9.0, I am 100% sure it is no longer with 0.9.1.

I did an inplace pip upgrade from 0.9.0 to 0.9.1, the former was a clean install in a new virtualenv.

Change History (2)

comment:1 Changed 4 years ago by kayhayen

I did the following. Downgrade to 0.9.0post1, all the build requests persisted. I couldn't find a button to cancel all builds globally. Since I have a lot of those tests, I chose to erase the sqlite database. It seemed the issue started for me 4 days ago. Every commit pushed since has become a build for nearly every builder. No way to catch up.

When I did two commits and pushed, a single collapsed build was performed for everything. This seems like a serious regression to me. Since I also drive release builds from this, even a dangerous one, corrupting release stuff.

Yours, Kay

comment:2 Changed 4 years ago by kayhayen

This also affects 0.9.0post1, my downgrade was ineffective.

Seems I fundamentally misunderstood this:

Either both source stamps are associated with changes, or neither
are associated with changes but they have matching revisions.

I don't even know what it means to be associated with changes. I just oversaw "matching" revisions. I of course assumed "contained" revisions, or otherwise this is really only about avoiding duplicate builds. Which apparently it is.

I was looking for the equivalent of this:

def mergeRequests(builder, req1, req2):
    "any requests with the same branch can be merged"
    return (req1.source.branch == req2.source.branch) and \
           req1.canBeMergedWith(req2)

c["mergeRequests"] = mergeRequests

This is from what I recall from documentation. Seems I will have a hard time to creating the equivalent.

Yours, Kay

Note: See TracTickets for help on using tickets.