Ticket #36 (closed enhancement: fixed)

Opened 6 years ago

Last modified 6 years ago

"round robin" build requests on idle slaves

Reported by: Pike Owned by: warner
Priority: major Milestone:
Version: Keywords:
Cc:

Description

I created a patch to (somewhat) round-robin build requests on idle slave. I'm using a random pick right now, as it's good enough for me, I have plenty of builders on a few slave when doing the repackaging of our 50-60 localizations of Mozilla Firefox.

As it's not really having a huge impact on the general flow with just one slave, I'm hopeful to get this landed upstream.

The change is to maybeStartBuild, and to not pick the first idle one, but a random one from all that are isAvailable.

Attachments

random-slave.patch Download (1.0 KB) - added by Pike 6 years ago.
pick random slave instead of first

Change History

Changed 6 years ago by Pike

pick random slave instead of first

comment:1 Changed 6 years ago by warner

  • Status changed from new to closed
  • Resolution set to fixed

I've updated the unit tests to accomodate this: several of the test_slaves.py checks depend upon the order in which the buildslaves are claimed (to see what happens when slaves are slow to respond to the pre-build ping). To this end, I made the random.choice conditional upon a Builder flag; those tests that depend upon ordering set this flag before running.

Other than that, it looks good, I'm committing it now. Thanks!

Note: See TracTickets for help on using tickets.