Opened 3 years ago

Closed 3 years ago

#3580 closed defect (fixed)

error not properly reported if buildbotUrl is miss configured

Reported by: tardyp Owned by: tardyp
Priority: major Milestone: 0.9.0
Version: master Keywords:
Cc:

Description

if buildbotUrl is misconfigured, a forcebuild will raise a invalid origin error, but it has a bad error code, which generates the wrong error, and is difficult to debug:

2016-07-12 13:29:09+0000 [HTTPChannel,26,192.198.151.44] While rendering resource:
        Traceback (most recent call last):
          File "/usr/lib/python2.7/site-packages/buildbot/www/rest.py", line 431, in render
            return self.asyncRenderHelper(request, self.asyncRender, writeError)
          File "/usr/lib/python2.7/site-packages/buildbot/www/resource.py", line 83, in asyncRenderHelper
            @d.addErrback
          File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 328, in addErrback
            errbackKeywords=kw)
          File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 306, in addCallbacks
            self._runCallbacks()
        --- <exception caught here> ---
          File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 588, in _runCallbacks
            current.result = callback(current.result, *args, **kw)
          File "/usr/lib/python2.7/site-packages/buildbot/www/resource.py", line 87, in failHttpError
            writeError(e.message, errcode=e.status)
          File "/usr/lib/python2.7/site-packages/buildbot/www/rest.py", line 427, in writeError
            request.setResponseCode(errcode)
          File "/usr/lib/python2.7/site-packages/twisted/web/http.py", line 1028, in setResponseCode
            raise TypeError("HTTP response code must be int or long")
        exceptions.TypeError: HTTP response code must be int or long

Change History (2)

comment:1 Changed 3 years ago by tardyp

  • Owner set to tardyp
  • Status changed from new to assigned

comment:2 Changed 3 years ago by tardyp

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.