Opened 22 months ago

#3542 new defect

consider users.srcs for email address lookup in MailNotifier

Reported by: reddot Owned by:
Priority: major Milestone: undecided
Version: 0.8.12 Keywords: mail
Cc:

Description

I'm trying to implement fetch of author emails for perforce source control. To understand how this should work I'm refering to GitPoller? implementation (it's noted in documentation that git users are translated to user objects). I've assumed that creating user objects from git changes should provide author emails for MailNotifier? without the need of special lookup function. However I found that doesn't work and it seems point is that MailNotifier? code looking for 'email' attribute of user object where GitPoller? stores email in 'git' attribute. Simply changing:

return users.getBuildContacts(self.master, build, email?)

to:

return users.getBuildContacts(self.master, build, email? + users.srcs)

do the trick. Could this change be incorporated to Buildbot upstream?

Change History (0)

Note: See TracTickets for help on using tickets.