Opened 2 years ago

Last modified 16 months ago

#3534 new defect

Issue in #2027 has made comeback

Reported by: cmouse Owned by:
Priority: minor Milestone: 0.9.+
Version: master Keywords: simple
Cc:

Description

2016-04-22 11:34:49+0300 [-] Unhandled error in Deferred: 2016-04-22 11:34:49+0300 [-] Unhandled Error

Traceback (most recent call last):

File "/opt/buildbot/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1184, in gotResult

_inlineCallbacks(r, g, deferred)

File "/opt/buildbot/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1131, in _inlineCallbacks

deferred.callback(getattr(e, "value", None))

File "/opt/buildbot/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 393, in callback

self._startRunCallbacks(result)

File "/opt/buildbot/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 501, in _startRunCallbacks

self._runCallbacks()

--- <exception caught here> ---

File "/opt/buildbot/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 588, in _runCallbacks

current.result = callback(current.result, *args, kw)

File "/opt/buildbot/local/lib/python2.7/site-packages/buildbot/www/change_hook.py", line 93, in ok

request.finish()

File "/opt/buildbot/local/lib/python2.7/site-packages/twisted/web/server.py", line 224, in finish

return http.Request.finish(self)

File "/opt/buildbot/local/lib/python2.7/site-packages/twisted/web/http.py", line 935, in finish

"Request.finish called on a request after its connection was lost; "

exceptions.RuntimeError?: Request.finish called on a request after its connection was lost; use Request.notifyFinish to keep track of this.

Change History (2)

comment:1 Changed 2 years ago by dustin

  • Keywords simple added
  • Milestone changed from undecided to 0.9.+
  • Priority changed from major to minor
  • Type changed from undecided to defect

#2027 has a patch that fixed this before. Basically, this exception should be caught and handled smoothly, rather than with an exception in the logfile.

Note: See TracTickets for help on using tickets.