Ticket #353 (closed defect: fixed)
Missing "got_revision" property ends up with value of 'None' instead of None
|Reported by:||exarkun||Owned by:|
buildbot/slave/commands.py, SourceBase._handleGotRevision unconditionally sends a status update for got_revision. The value may be None. This ends up in the command's updates dict on the server. buildbot/steps/source.py, Source.commandComplete checks to see if got_revision is in the updates dict. If so, it passes the last value to str (turning None into "None") and sets the value as the "got_revision" property. This confounds any other code that expects to see None if there was no got_revision property. In other words, builder.getProperty returns "None" where it should return None. This has a side effect of persisting bogus data as well, the fix for which I'm not entirely clear on.