Opened 3 years ago

Last modified 3 years ago

#3482 new undecided

remove master logic from slave/buildslave/scripts/ or unify implementation in master and worker

Reported by: rutsky Owned by:
Priority: major Milestone: undecided
Version: master Keywords:

Description in master and slave source directories are almost same, but in slave has logic which should made to be usable in master and worker implementations.

I think we should:

1) either remove "master" logic from in worker code and treat in master and worker as independed modules.

2) or use exactly same in master and worker sources, with support of master and worker logic.

What approach is better?

Change History (1)

comment:1 Changed 3 years ago by rutsky

BTW, this line is incorrect for about 5 years:

        if "Creating BuildSlave" in line:
            self.processtype = "buildslave"

(since this commit), and in worker generates BuildmasterTimeoutError instead BuildslaveTimeoutError, but this doesn't bother anyone, because both exceptions are handled in worker code:

Note: See TracTickets for help on using tickets.