Opened 3 years ago

Closed 3 years ago

#3475 closed defect (fixed)

collapseRequests option does not work

Reported by: pranit.sirsat Owned by:
Priority: major Milestone: 0.9.0
Version: 0.9.0b7 Keywords: collapseRequests, Gerrit
Cc:

Description

i have tested it on 0.9.0b5 and 0.9.0b7 versions.

the example given in the docs for "collapseRequests" http://docs.buildbot.net/latest/manual/customization.html?highlight=collapserequests#collapse-request-functions doesn't work (i use the GerritChangeSource?). the req1 and req2 are not passed as objects but as dictinaries.

i tried providing the "collapseRequests" option in both global config as well as in builder config but it shows same behaviour.

also i tried by writing simple function for collapseRequest which always return True, and the changesets from same gerrit project with same patch number same codebase were added to buildbot but they were not merged. also tried by writing function that always returns False but that also did not work.

Change History (2)

comment:1 Changed 3 years ago by dustin

  • Milestone changed from undecided to 0.9.0
  • Type changed from undecided to defect

comment:2 Changed 3 years ago by tardyp

  • Resolution set to fixed
  • Status changed from new to closed

there is a big warning in the doc:

.. warning:

This section is no longer accurate in Buildbot 0.9.x

I believe that collapseRequest works as expected, as I have several support from people who accidentally have it enabled.

Creating another ticker to fix the doc

Note: See TracTickets for help on using tickets.