Test step appends "no test results" over and over

[warner]

The Test step is modifying a class-level list in place (with append), and as a result, each time a build has no test results, all builds which use a Test step will have an increasing number of copies of "no test results" appear in their descriptions. Oops.

The fix is the following patch:

--- old-TRUNK/buildbot/steps/shell.py	2008-09-17 11:36:01.000000000 -0700
+++ new-TRUNK/buildbot/steps/shell.py	2008-09-17 11:36:01.000000000 -0700
@@ -116,9 +116,9 @@
         """
 
         if done and self.descriptionDone is not None:
-            return self.descriptionDone
+            return list(self.descriptionDone)
         if self.description is not None:
-            return self.description
+            return list(self.description)
 
         properties = self.build.getProperties()
         words = self.command
@@ -401,8 +401,6 @@
                     description.append('%d warnings' % warnings)
                 if failed:
                     description.append('%d failed' % failed)
-            else:
-                description.append("no test results")
         return description
 
 class PerlModuleTest(Test):

(I removed the append("no test results") call because a lot of installations use the Test step without a test parser, and "no test results" is not really adding a lot of information.)

[tjc]

#359 was created as a result of this problem, although I have now closed it as a duplicate. The patch above fixed it. I hope this can make it into a new release of buildbot soon!

[djc]

This is biting us, too.

[wangdong]

Replying to djc:

This is biting us, too.

me2, and if the tests results may appends over and over.

[mue]

I tried the patch and can confirm that it works.

[djc]

This really makes buildbot kind of useless. Could it get fixed, please?

[tjc]

Why can't this relatively trivial patch be applied? Is development actually on-going? I can't see any changes in the last 4+ months in the source browser :(

[dustin]

Sorry, I didn't see this 'cuz it's not kw'd "review"

[thijs]

Thanks for the patch, that 'no test results' was awkward and is gone now. Though it's still reporting successful builds when in fact they should be reported as failed, as described in #275

[dustin]

Sorry, this was committed, but I forgot to close the bug:

commit a3c7af35410d2ed4aa4a238f653ebf51197f7760
Author: Brian Warner <warner-buildbot@lothar.com>
Date:   Tue Jan 6 11:49:18 2009 -0500

    (closes #347) I removed the append ("no test results") call because a lot of installations use the Test step without a test parser, and "no test results" is not really adding a lot of information.