FileUpload: automatically create target directory

[gward]

From a message on the buildbot-devel mailing list:

I am using buildbot and I wish to ship files from the slave to distinct dir on the master depending on the current date eg.

f.addStep(FileUpload(
  slavesrc="~//releases_ui_tests_3.2_branch/summary_reports.log",
  masterdest="~/summary_logs/2008-08-26/summary_reports.log"))

As can be seen on the master the 2008-08-26 part of the path changes every day...

Is there any way, via buildbot, I can have the buildmaster automatically create these dir so the FileUpload? command can succeed (as the dir for the next day i.e 2008-08-27 does not exist on the master)

[gward]

Patch to implement this feature (from mailing list; untested by me)

[dustin]

Looks good. I made one modification, changing os.path.isdir to os.path.exists -- that way we won't try to mkdirs if there is a file of the same name. Ted Zlatanov <tzz@…> suggested this.

 http://repo.or.cz/w/buildbot.git?a=shortlog;h=refs/remotes/dustin/bug341

This has no tests, but FileUpload? in general has no tests, so I'm inclined to just take it.

[dustin]

I also added a line to make the filename absolute first -- this fixes the case where the filename is unqualified (e.g., "test.diff"), which happens to be tickled by the unit tests.

[jimmyj_in]

We will also have to update the buildbot manual for this change.

Section 6.1.7, the last line reads as:

"Remember that neither of these commands will create missing directories for you."

We will have to update this to indicate that FileUpload? will now create directories if they do not exist.

Thanks

Jimmy

[dustin]

good point; might as well make FileDownload? do the same thing

[warner]

this pair of patches looks good to me.. dustin, go ahead and push

[warner]

released, in buildbot-0.7.9