![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
Ticket #339 (new enhancement)
inline logs in HTML Emails and capture errors in Compile
| Reported by: | tzz | Owned by: | dustin |
|---|---|---|---|
| Priority: | patches-accepted | Milestone: | 0.8.+ |
| Version: | 0.7.8 | Keywords: | |
| Cc: | kovarththanan.rajaratnam@… |
Description
- inline logs (with inlineLogs=true) in the message. At least for Outlook users, this is a big convenience.
- capture and produce errors on a compile. I created WarningCountingShellCommand2 to do this, in case we needed to go back, but it's just a copy of WarningCountingShellCommand? with extra behavior so it should superced it.
Attachments
-
err+inline.patch
(4.9 KB) -
added by tzz 5 years ago.
-
err.patch
(4.2 KB) -
added by tzz 5 years ago.
- shell.py patch to count errors
Change History
comment:2 Changed 5 years ago by dustin
- Milestone changed from undecided to 0.7.9
http://repo.or.cz/w/buildbot.git?a=shortlog;h=refs/remotes/dustin/bug339
I only added the first hunk -- inline emails.
Can you re-draft the second hunk so that it doesn't involve the wholesale copying of a class?
comment:3 Changed 5 years ago by dustin
- Milestone changed from 0.7.9 to undecided
sorry, also please supply a documentation patch for the inlineLogs parameter.
comment:4 Changed 5 years ago by tzz
I'm sorry but due to work pressure I simply don't have the time to edit the docs. The changes are simply:
inlineLogs (default False): set to True to have all logs inside the notification e-mail in addition to being attached.
Compile (WarningCountingShellCommand?): counts and sets the number of errors exactly as it does with warnings. The parameter errorPattern can be used to tune the detection of errors.
I can do the docs next week, but to get the code in the source tree I'm submitting just the code patch for WarningCountingShellCommand? in shell.py.