Opened 10 years ago

Closed 4 years ago

Last modified 3 years ago

#339 closed enhancement (no-response)

inline logs in HTML Emails and capture errors in Compile

Reported by: tzz Owned by: dustin
Priority: patches-accepted Milestone: 0.8.+
Version: 0.7.8 Keywords: mail
Cc: kovarththanan.rajaratnam@…

Description (last modified by dustin)

  • inline logs (with inlineLogs=true) in the message. At least for Outlook users, this is a big convenience.
  • capture and produce errors on a compile. I created WarningCountingShellCommand2 to do this, in case we needed to go back, but it's just a copy of WarningCountingShellCommand? with extra behavior so it should superced it.

Attachments (2)

err+inline.patch (4.9 KB) - added by tzz 10 years ago.
err.patch (4.2 KB) - added by tzz 10 years ago. patch to count errors

Download all attachments as: .zip

Change History (14)

Changed 10 years ago by tzz

comment:1 Changed 10 years ago by tzz

this is reported by Ted Zlatanov <tzz@…>

comment:2 Changed 10 years ago by dustin

  • Milestone changed from undecided to 0.7.9;h=refs/remotes/dustin/bug339

I only added the first hunk -- inline emails.

Can you re-draft the second hunk so that it doesn't involve the wholesale copying of a class?

comment:3 Changed 10 years ago by dustin

  • Milestone changed from 0.7.9 to undecided

sorry, also please supply a documentation patch for the inlineLogs parameter.

comment:4 Changed 10 years ago by tzz

I'm sorry but due to work pressure I simply don't have the time to edit the docs. The changes are simply:

inlineLogs (default False): set to True to have all logs inside the notification e-mail in addition to being attached.

Compile (WarningCountingShellCommand?): counts and sets the number of errors exactly as it does with warnings. The parameter errorPattern can be used to tune the detection of errors.

I can do the docs next week, but to get the code in the source tree I'm submitting just the code patch for WarningCountingShellCommand? in

Changed 10 years ago by tzz patch to count errors

comment:5 Changed 9 years ago by dustin

  • Owner set to dustin

assigning to me for documentation and re-implementation

comment:6 Changed 9 years ago by dustin

  • Milestone changed from undecided to 0.7.+

comment:7 Changed 8 years ago by dustin

  • Keywords mail added

comment:8 Changed 7 years ago by krajaratnam

  • Cc kovarththanan.rajaratnam@… added

comment:9 Changed 6 years ago by dustin

I've totally lost track of what's required here?

comment:10 Changed 5 years ago by dustin

  • Priority changed from minor to patches-accepted

comment:11 Changed 4 years ago by dustin

  • Description modified (diff)
  • Resolution set to no-response
  • Status changed from new to closed

comment:12 Changed 3 years ago by dustin

There is a pull request to accomplish part of this bug -

However, it's against Buildbot eight, and needs to be rewritten to apply against master.

Note: See TracTickets for help on using tickets.