Opened 3 years ago

#3385 new defect

change_hook_auth doesn't accept "file:changehook.passwd"

Reported by: verm Owned by:
Priority: major Milestone: undecided
Version: master Keywords: hook
Cc:

Description

There's clearly something missing as it's passing the string directly which causes an error.

The test uses a memory DB which is why it passes.

2015-11-18 18:34:46+0000 [-] while starting BuildMaster
        Traceback (most recent call last):
          File "/data/buildbot/env/lib/python2.7/site-packages/twisted/internet/defer.py", line 1184, in gotResult
            _inlineCallbacks(r, g, deferred)
          File "/data/buildbot/env/lib/python2.7/site-packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks
            result = g.send(result)
          File "/data/buildbot/buildbot/master/buildbot/util/service.py", line 46, in reconfigServiceWithBuildbotConfig
            yield svc.reconfigServiceWithBuildbotConfig(new_config)
          File "/data/buildbot/env/lib/python2.7/site-packages/twisted/internet/defer.py", line 1274, in unwindGenerator
            return _inlineCallbacks(None, gen, Deferred())
        --- <exception caught here> ---
          File "/data/buildbot/env/lib/python2.7/site-packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks
            result = g.send(result)
          File "/data/buildbot/buildbot/master/buildbot/www/service.py", line 73, in reconfigServiceWithBuildbotConfig
            self.setupSite(new_config)
          File "/data/buildbot/buildbot/master/buildbot/www/service.py", line 169, in setupSite
            resource_obj, change_hook_auth)
          File "/data/buildbot/buildbot/master/buildbot/www/service.py", line 232, in setupProtectedResource
            portal = Portal(SimpleRealm(), checkers)
          File "/data/buildbot/env/lib/python2.7/site-packages/twisted/cred/portal.py", line 65, in __init__
            self.registerChecker(checker)
          File "/data/buildbot/env/lib/python2.7/site-packages/twisted/cred/portal.py", line 77, in registerChecker
            credentialInterfaces = checker.credentialInterfaces
        exceptions.AttributeError: 'str' object has no attribute 'credentialInterfaces'
        

Change History (0)

Note: See TracTickets for help on using tickets.