Ticket #337 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

Sendchange doesn't resolve revision correctly for subversion

Reported by: ronald.lew Owned by:
Priority: minor Milestone: 0.7.9
Version: 0.7.8 Keywords:
Cc:

Description

When sending a sendchange request mimicking a subversion changeset without specifying a revision number, the HEAD revision isn't resolved correctly but instead an error is thrown as specified below: 

  File "/usr/lib/python2.5/site-packages/buildbot-0.7.8-py2.5.egg/buildbot/steps/source.py", line 400, in computeSourceRevision
    lastChange = max([int(c.revision) for c in changes])
exceptions.TypeError: int() argument must be a string or a number, not 'NoneType'

Attachments

patch Download (376 bytes) - added by ronald.lew 5 years ago.
Patch file for ticket #337

Change History

Changed 5 years ago by ronald.lew

Patch file for ticket #337

comment:1 Changed 5 years ago by dustin

  • Keywords review added

comment:2 Changed 5 years ago by dustin

  • Keywords review, devtree added; review removed

 http://repo.or.cz/w/buildbot.git?a=shortlog;h=refs/remotes/dustin/bug337

comment:3 Changed 5 years ago by dustin

  • Milestone changed from undecided to 0.7.9

comment:4 Changed 5 years ago by warner

  • Status changed from new to closed
  • Resolution set to fixed

applied, in buildbot-0.7.9 . In the future, please include the ticket number in the checkin comments.. this will help me manage the release notes.

comment:5 Changed 4 years ago by dustin

  • Keywords review, devtree removed
Note: See TracTickets for help on using tickets.