Ticket #334 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

when builds are pending on multiple builders, buildbot gives priority to builders currently building

Reported by: bhearsum Owned by:
Priority: major Milestone: 0.7.10
Version: 0.7.7 Keywords:
Cc: Pike, catlee

Description

We have builders for a few different branches. When a slew of checkins happens on one, all of our slaves end up being used for it. If more build requests come in while they are building, the next free slave will end up with a build from that same builder again, even if there are jobs that have been pending for longer. I believe the most basic behaviour should be FIFO.

This may end up getting fixed as part of a larger prioritization bug, but I thought I should file it anyways.

Attachments

build-priority.patch Download (3.1 KB) - added by catlee 4 years ago.
Prioritize build requests based on the time they were submitted

Change History

comment:1 Changed 5 years ago by Pike

  • Cc Pike added

Is this due to the way that maybeStartBuild works?

Changed 4 years ago by catlee

Prioritize build requests based on the time they were submitted

comment:2 Changed 4 years ago by catlee

  • Cc catlee added

comment:3 Changed 4 years ago by Pike

Want to create a git branch for this?

Can you create a testcase for this, too?

The fix looks ok for me, though.

comment:4 Changed 4 years ago by catlee

I have a git branch available at  http://atlee.ca/software/buildbot, which has all my local changes, not just this one. I'll look into creating a test case.

comment:5 Changed 4 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

ok, this is committed, along with a unit test. thanks!

comment:6 Changed 4 years ago by dustin

  • Milestone changed from undecided to 0.7.10
Note: See TracTickets for help on using tickets.