Opened 4 years ago

Closed 4 years ago

#3326 closed undecided (invalid)

GerritChangeFilter error with Buildbot 0.8.12

Reported by: simark Owned by:
Priority: major Milestone: undecided
Version: 0.8.10 Keywords:
Cc:

Description

I trying to set up a GerritChangeSource? with a GerritChangeFilter?. I want to filter down the changes to a single gerrit project, so I create a filter as follows, which I pass to AnyBranchScheduler?:

GerritChangeFilter(project='owner/project')

When a non-matching event comes up, it works and no exception it generated. WHen a matching event comes up, this is what I get in twistd.log:

2015-08-03 16:57:15-0400 [-] while invoking callback <function changeCallback at 0x7ff2afa5d140> to <SubscriptionPoint 'changes'>
	Traceback (most recent call last):
	  File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py", line 393, in callback
	    self._startRunCallbacks(result)
	  File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py", line 501, in _startRunCallbacks
	    self._runCallbacks()
	  File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py", line 588, in _runCallbacks
	    current.result = callback(current.result, *args, **kw)
	  File "/usr/local/lib/python2.7/dist-packages/buildbot/master.py", line 513, in notify
	    self._change_subs.deliver(change)
	--- <exception caught here> ---
	  File "/usr/local/lib/python2.7/dist-packages/buildbot/util/subscription.py", line 37, in deliver
	    sub.callback(*args, **kwargs)
	  File "/usr/local/lib/python2.7/dist-packages/buildbot/schedulers/base.py", line 175, in changeCallback
	    if change_filter and not change_filter.filter_change(change):
	  File "/usr/local/lib/python2.7/dist-packages/buildbot/changes/filter.py", line 86, in filter_change
	    chg_val = change.properties.get(chg_attr.split(":", 1)[1], '')
	exceptions.AttributeError: Properties instance has no attribute 'get'

Change History (2)

comment:1 Changed 4 years ago by simark

As I was about to submit a patch based on the 0.8.12 code, I noticed that this was fixed at HEAD of the eight branch (commit e4d5d7d). I'll try to use the code from that branch instead of from PyPI (but will still wait eagerly for a 0.8.13 package :) ).

Last edited 4 years ago by simark (previous) (diff)

comment:2 Changed 4 years ago by simark

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.