Ticket #327 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

Git VC slave command neglects to fetch non-branch-head tags

Reported by: jgill Owned by:
Priority: patches-accepted Milestone: 0.7.10
Version: 0.7.8 Keywords: git tag
Cc:

Description

I started working with buildbot for the first time today - for what it's worth, it's a great package. One immediate problem I see, however, is that the Git class in buildbot/slave/commands.py fails to fetch tags that don't point to a branch head. For a package I work on, I rely on the output of git describe --tags in the build process to determine version and release numbers. These numbers are unavailable for HEAD revs that aren't individually tagged.

The solution to my problem is trivial: add a -t argument to the git-fetch command, such as is provided in my attached patch.

Attachments

git-fetch-327.patch Download (551 bytes) - added by jgill 5 years ago.
patch to add '-t' arg to git-fetch commandline

Change History

Changed 5 years ago by jgill

patch to add '-t' arg to git-fetch commandline

comment:1 Changed 4 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from undecided to 0.7.10

Looks good 

Created commit cc8a640: (refs #327) fetch git tags, too
 1 files changed, 1 insertions(+), 1 deletions(-)
Note: See TracTickets for help on using tickets.