Opened 5 years ago

Closed 5 years ago

#3255 closed defect (fixed)

Properties should send update events.

Reported by: riziero Owned by: tardyp
Priority: major Milestone: 0.9.0
Version: master Keywords:
Cc:

Description (last modified by tardyp)

Original title: Build page not showing properties when build contains a trigger step

builder with just 1 trigger step that kicks off 4 builders.

Propeties do not show up until the build is done. Refreshing does not help.

I've uploaded a shot: http://postimg.org/image/hzn2tpee7/

Twisted.log says:

REST error: not found while getting from endpoint for /builds/n:buildid /builders/n:builderid/builds/n:number with arguments ResultSpec?({'fields': None, 'limit': None, 'order': None, 'filters': [], 'offset': None}) and {'number': 11, 'builderid': 4}

Change History (14)

comment:1 Changed 5 years ago by tardyp

Hi riziero,

From you symptoms, it looks like there is a javascript error. Could your please look at the JS console of your browser (F12 key shortcut), and send us eventual error?

I would advise you to use http://snag.gy/3S2hi.jpg for sharing images later. It has less ads

comment:2 Changed 5 years ago by riziero

Thanks for taking the time to look at this.

Indeed I get a bunch of errors on the JS side. During the process, when the build is on going

http://snag.gy/WJ1E5.jpg

After the build is over (thus properties can actually be seen on the web page):

http://snag.gy/ntpNc.jpg

Are those links being generated wrongly? BTW the code behind this Buildbot installation is quite old, perhaps three months old.

comment:3 Changed 5 years ago by tardyp

Hi riziero.

If you have old buildbot code, then I dont think it is a good idea to continue to debug, you should first upgrade to latest master.

In your log, this is normal to have some of the 404 errors (in order to detect if the next build button should be disabled, we do a rest call that may 404)

What is anormal is the get on /builds/properties. This should be a get on /builds/<id>/properties.

I have a buildbot nine in production right now, which is running buildbot_travis, and has trigger builds, the properties are working.

comment:5 Changed 5 years ago by riziero

Yeah I've had this problem ever since I installed it. As I get the chance I'll set a new up from latest code and update this page.

Cheers!

comment:6 Changed 5 years ago by riziero

Latest code, installed on a new lint and mint system. Same problem.

Edit:

http://snag.gy/8WH5z.jpg

The only difference I can see is that I am triggering more than one builder

Last edited 5 years ago by riziero (previous) (diff)

comment:7 Changed 5 years ago by riziero

Any idea how I can debug this?

comment:8 Changed 5 years ago by dustin

@tardyp - any idea if this has been corrected?

comment:9 Changed 5 years ago by tardyp

It is a problem of event management. We should propagate event when properties have changed.

Should send the event here: https://github.com/buildbot/buildbot/blob/master/master/buildbot/data/properties.py#L52

comment:10 Changed 5 years ago by riziero

Not sure if this is related but properties do not show up even when there is no step making up the factory.

comment:11 Changed 5 years ago by tardyp

  • Description modified (diff)
  • Summary changed from Build page not showing properties when build contains a trigger step to Properties should send update events.

comment:12 Changed 5 years ago by tardyp

  • Owner set to tardyp
  • Status changed from new to assigned

comment:14 Changed 5 years ago by tardyp

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.