eight: category/tag filtering on MailNotifier not functioning as expected

[cody]

Here's a sanitized excerpt from my master.cfg:

c['status'].append(mail.MailNotifier(
                fromaddr="buildbot@localhost",
                lookup="foo.com",
                sendToInterestedUsers=True,
                mode='warnings',
                categories= ['stable']))

c['builders'].append({
    'name':      'foo-stable',
    'slavenames': foo_slave_names,
    'builddir':  "foo-stable",
    'factory':   f_foo(),
    'category' : 'stable'
})

c['builders'].append({
    'name':      'foo-unstable',
    'slavenames': foo_slave_names,
    'builddir':  "foo-unstable",
    'factory':   f_foo_unstable(),
})

c['builders'].append({
    'name':      'foo-bad',
    'slavenames': foo_slave_names,
    'builddir':  "foo-really-bad",
    'factory':   f_foo_bad(),
    'category': 'unstable'
})

On 0.8.10, this worked as expected (no emails for foo-unstable). On d4bdf212b7b53e8dc7c0590d70f8ca54714c005c (eight as of today) at least the builds marked as 'unstable' are also sending out emails.

I haven't checked whether un-categorized builds are resulting in mail being sent.

[cody]

Also: in the web portal clicking the 'stable' tag in waterfall view shows all builds _not_ categorized as 'stable' instead of showing just the builds categorized as 'stable'

[adiroiban]

not sure how to link with github PR so here it goes ​https://github.com/buildbot/buildbot/pull/1576