Opened 6 years ago

Last modified 6 years ago

#3216 new enhancement

extraRecipients in MailNotifier should support renderable

Reported by: vlovich Owned by:
Priority: patches-accepted Milestone: undecided
Version: 0.8.10 Keywords:
Cc:

Description

The set of extraRecipients is not necessarily a hard-coded list & may depend on the properties of the build. For example, if there are multiple codebases.

Attached a CustomMailNotifier (untested yet) that overrides MailNotifier a bit to provide this functionality.

Attachments (1)

mail.py (2.4 KB) - added by vlovich 6 years ago.
Custom mail notifier where extraRecipients can be renderable

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by vlovich

Custom mail notifier where extraRecipients can be renderable

comment:1 Changed 6 years ago by vlovich

Note: extraRecipients is still an array. If the renderable returns an array we flatten it.

An alternate implementation would make extraRecipients renderable. I decided on this approach because you might still want to provide a hard-coded set of addresses along-side the renderable.

comment:2 Changed 6 years ago by sa2ajj

  • Priority changed from major to patches-accepted

Reviewing attachments is not that convenient in Trac :)

I'd suggest you submit a PR to update MailNotifier so we could have a discussion there.

comment:3 Changed 6 years ago by vlovich

Submitted https://github.com/buildbot/buildbot/pull/1571 as requested. It's based off of the 0.8.11 tag.

The 0.9 one changed a bit so I was less confident basing my work off that.

Note: See TracTickets for help on using tickets.