Opened 2 years ago

Closed 6 months ago

#3197 closed defect (fixed)

GerritChangeSource fails with commit messages longer than 1024 characters

Reported by: ims Owned by:
Priority: major Milestone: 0.9.+
Version: 0.8.10 Keywords: gerrit, database, simple
Cc:

Description (last modified by sa2ajj)

GerritChangeSource adds all change event values received from Gerrit as change properties, one of which is the commit message (event.change.commitMessage). In the schema as included in Buildbot 0.8.10 change property values are limited to 1024 characters.

At least when using PostgreSQL, insertion of properties fails and the received event is ignored.

… error adding change from GerritChangeSource
…
sqlalchemy.exc.DataError: (DataError) value too long for type character varying(1024)
'INSERT INTO change_properties (changeid, …

The field change_properties.property_value should be changed to TEXT as already done for buildset_properties.property_value and changes.comments in ticket #2367.

Change History (4)

comment:1 Changed 2 years ago by sa2ajj

  • Description modified (diff)
  • Keywords gerrit added

comment:2 Changed 2 years ago by dustin

  • Keywords database added
  • Milestone changed from undecided to 0.9.0

comment:3 Changed 23 months ago by dustin

  • Keywords simple added
  • Milestone changed from 0.9.0 to 0.9.+

This should be migrated to a "TEXT" column

comment:4 Changed 6 months ago by tardyp

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.