Opened 6 years ago

Closed 6 years ago

#3191 closed defect (fixed)

TestRealDB.test_getChangesForBuild failing for postgres

Reported by: dustin Owned by: dustin
Priority: blocker Milestone: 0.9.0b1
Version: master Keywords:
Cc:

Description

Traceback (most recent call last):
  File "/var/lib/buildslave/bbot/db-postgres/sandbox-python-twistedsamigr-0.7.1/lib/python2.7/site-packages/twisted/internet/defer.py", line 1020, in _inlineCallbacks
    result = g.send(result)
  File "/var/lib/buildslave/bbot/db-postgres/build/master/buildbot/test/unit/test_db_changes.py", line 981, in test_getChangesForBuild
    sorted(expected_2ndBuild))
twisted.trial.unittest.FailTest: not equal:
a = []
b = [{'author': u'delanne',
  'branch': u'master',
  'category': u'cat',
  'changeid': 4,
  'codebase': u'',
  'comments': u'4th commit',
  'files': [],
  'parent_changeids': [1],
  'project': u'proj',
  'properties': {},
  'repository': u'repo',
  'revision': u'2',
  'revlink': u'http://vc/abcd',
  'sourcestampid': 4,
  'when_timestamp': datetime.datetime(1970, 8, 25, 2, 16, 17, tzinfo=tzutc())}]


buildbot.test.unit.test_db_changes.TestRealDB.test_getChangesForBuild

Bisect shows this failing frequently quite a ways back - back to December 2014.

Change History (3)

comment:1 Changed 6 years ago by dustin

Git bisect blames a52fcdda6797681bd33c00d358dbbff8d066b18b which is obviously unrelated:

commit a52fcdda6797681bd33c00d358dbbff8d066b18b
Author: MaximeSangoi <maxime.sangoi@gmail.com>
Date:   Fri Dec 19 16:55:44 2014 +0100

    Add new module to left menu

 www/base/src/app/settings/settings.controller.coffee |  9 +++++++++
 www/base/src/app/settings/settings.route.coffee      | 27 +++++++++++++++++++++++++++
 www/base/src/app/settings/settings.tpl.jade          |  9 +++++++++
 3 files changed, 45 insertions(+)

Bisecting just changes in master/ blames 3f160a806dd8795e6ffc5b8c241c89f3cc4160fd, which also *seems* unrelated, but I can repeatedly see the failure at that commit but not at its parent, 55446d2. The commit is

commit 3f160a806dd8795e6ffc5b8c241c89f3cc4160fd
Author: Pierre Tardy <pierre.tardy@intel.com>
Date:   Fri Jan 23 21:50:41 2015 +0100

    fix tests
    
    Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>

diff --git a/master/buildbot/test/fake/fakedb.py b/master/buildbot/test/fake/fakedb.py
index 9b4f4ea..3b4b4db 100644
--- a/master/buildbot/test/fake/fakedb.py
+++ b/master/buildbot/test/fake/fakedb.py
@@ -827,16 +827,19 @@ class FakeChangesComponent(FakeDBComponent):
         return defer.succeed(chdicts)
 
     def getChangesCount(self):
         return len(self.changes)
 
     def getChangesForBuild(self, buildid):
         pass
 
+    def getChangeFromSSid(self, ssid):
+        pass
+
     def _chdict(self, row):
         chdict = row.copy()
         del chdict['uids']
         if chdict['parent_changeids'] is None:
             chdict['parent_changeids'] = []
 
         chdict['when_timestamp'] = _mkdt(chdict['when_timestamp'])
         return chdict

comment:3 Changed 6 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.