Opened 3 years ago

Last modified 8 months ago

#3108 new defect

SSE requests returning conflicting status codes

Reported by: Ben Owned by:
Priority: major Milestone: 1.0.+
Version: master Keywords: web
Cc:

Description

The request are returning a 200 status code, but in the body is a (hidden) 500.

Example:

ok
<html>
  <head><title>500 - Request did not return bytes</title></head>
  <body>
    <h1>Request did not return bytes</h1>
    <p>Request: <pre>&lt;Request at 0x60af368 method=GET uri=/sse/add/89c62c11-5652-4906-ac9d-bc5636e575c3/buildsets/748/* clientproto=HTTP/1.0&gt;</pre><br />Resource: <pre>&lt;buildbot.www.sse.EventResource instance at 0x41e0b00&gt;</pre><br />Value: <pre>None</pre></p>
  </body>
</html>

This was first seen on nine.b.n with the builds/*/* url.

Change History (10)

comment:1 Changed 3 years ago by tardyp

I think this is a false error. The request is accounted, but it returns something that twisted web does not like

comment:2 Changed 3 years ago by dustin

I'm confused. From this and https://github.com/buildbot/buildbot/pull/1439 it sounds like this got figured out. Can we close this bug?

comment:3 Changed 3 years ago by Ben

@dustin, That PR (1439) is not related, I just tried to explain why the view was not dynamic as I expected with this issue, which according to @tardyp is not the correct explanation.

This issue is just about an inconsistent confusing message I saw in my logs. So far I didn't linked this behavior (500 in the body of the 200) to any malfunction directly.

comment:4 Changed 3 years ago by dustin

  • Summary changed from /sse/add/uu-i-d/ request not working as they should. to SSE requests returning conflicting status codes

comment:5 Changed 3 years ago by sa2ajj

  • Keywords web added

comment:6 Changed 3 years ago by dustin

  • Priority changed from critical to major

comment:7 Changed 2 years ago by dustin

@tardyp - I don't think we're using SSE anymore -- can this be closed up?

comment:8 Changed 22 months ago by tardyp

I think sse is really practical to implement straight forward remote build triggering and waiting. I would need to provide a simple example of that in the doc

comment:9 Changed 22 months ago by dustin

  • Milestone changed from 0.9.0 to 1.0.+

OK, but not a blocker to 0.9.0

Note: See TracTickets for help on using tickets.