Opened 4 years ago

Closed 4 years ago

#3103 closed defect (fixed)

error during master shutdown

Reported by: sa2ajj Owned by: tardyp
Priority: major Milestone: 0.9.0
Version: master Keywords:
Cc:

Description

From twistd.log:

2014-12-08 19:02:14+0000 [-] Unhandled error in Deferred:
2014-12-08 19:02:14+0000 [-] Unhandled Error
        Traceback (most recent call last):
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/internet/defer.py", line 423, in errback
            self._startRunCallbacks(fail)
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/internet/defer.py", line 490, in _startRunCallbacks
            self._runCallbacks()
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/internet/defer.py", line 577, in _runCallbacks
            current.result = callback(current.result, *args, **kw)
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/internet/defer.py", line 1155, in gotResult
            _inlineCallbacks(r, g, deferred)
        --- <exception caught here> ---
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/internet/defer.py", line 1097, in _inlineCallbacks
            result = result.throwExceptionIntoGenerator(g)
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
            return g.throw(self.type, self.value, self.tb)
          File "/usr/home/bbmaster/buildbot/master/buildbot/master.py", line 284, in stopService
            name=self.name, masterid=self.masterid)
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/internet/defer.py", line 1097, in _inlineCallbacks
            result = result.throwExceptionIntoGenerator(g)
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
            return g.throw(self.type, self.value, self.tb)
          File "/usr/home/bbmaster/buildbot/master/buildbot/data/masters.py", line 132, in masterStopped
            yield self._masterDeactivated(masterid, name)
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/internet/defer.py", line 1099, in _inlineCallbacks
            result = g.send(result)
          File "/usr/home/bbmaster/buildbot/master/buildbot/data/masters.py", line 164, in _masterDeactivated
            stepid=step['stepid'], results=RETRY)
          File "/usr/home/bbmaster/master/lib/python2.7/site-packages/twisted/internet/defer.py", line 1228, in unwindGenerator
            gen = f(*args, **kwargs)
        exceptions.TypeError: finishStep() takes exactly 4 arguments (3 given)

Change History (3)

comment:1 Changed 4 years ago by dustin

  • Owner set to dustin
  • Status changed from new to assigned

How on earth did I manage to get that wrong? That'll need some attention to the tests.

comment:2 Changed 4 years ago by dustin

  • Owner changed from dustin to tardyp

comment:3 Changed 4 years ago by sa2ajj

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged.

Note: See TracTickets for help on using tickets.