Opened 6 years ago

Closed 6 years ago

#3073 closed defect (fixed)

Steps in Canceled build are still running.

Reported by: Ben Owned by: dustin
Priority: minor Milestone: 0.9.0
Version: master Keywords:
Cc:

Description

It looks like I restarted my master while some build were running. The build themselves are pink (never saw that color there before), the status is marked as 'RETRY', but the last step in the build is still marked as running (yellow), and its pill is heartbeating ...

Change History (6)

comment:1 Changed 6 years ago by Ben

BTW, I wonder if 'RETRY' is the right term for that, shouldn't it better be 'RETRIED', or 'CANCELLED' ?

comment:2 Changed 6 years ago by dustin

The status names are an odd bunch of English parts of speech, mostly nouns - "FAILURE" instead of "FAILED", "WARNINGS" instead of "WARNING", etc.

That said, CANCELLED means that the build was stopped and will not be run again; RETRY means that the build was stopped and rescheduled, which is the case here.

We will need to be more careful to mark steps in stopped builds as stopped, though.

comment:3 Changed 6 years ago by dustin

  • Owner set to dustin
  • Status changed from new to assigned

comment:5 Changed 6 years ago by Mikhail Sobolev <mss@…>

In 05c400883e077393249076c5008da6560e0bb799:

Merge pull request #1408 from djmitche/bug3073

Refactor housekeeping when a master stops

comment:6 Changed 6 years ago by dustin

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.