Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3055 closed defect (fixed)

Master-side SVN steps use much shorter timeout when removing a working copy

Reported by: bdash Owned by: Mark Rowe <mrowe@…>
Priority: major Milestone: 0.8.x
Version: 0.8.9 Keywords: svn


When a working copy is bogus or was locked, the SVN steps attempt to remove the working copy. However, the "rm -rf" command that they use has a much shorter timeout (120 seconds) than the SVN operations. With huge SVN repositories such as WebKit's, deleting the working copy can easily take more than 120 seconds. This results several builds in a row failing until the sequence of attempted removals eventually removes the entirety of the working copy.

svn --version
 in dir …/build/OpenSource (timeout 1200 secs)

rm -rf …/build/OpenSource
 in dir … (timeout 120 secs)

Change History (4)

comment:2 Changed 6 years ago by sa2ajj

  • Milestone changed from undecided to 0.8.x

comment:3 Changed 6 years ago by Mark Rowe <mrowe@…>

  • Owner set to Mark Rowe <mrowe@…>
  • Resolution set to fixed
  • Status changed from new to closed

In d982ba18c17ea42665d35e21be2de1a68f7e5cac:

Have master-side SVN steps respect the timeout when removing files and directories.

Teach CompositeStepMixin?.runRmdir to respect any timeout from the step.

Fixes ticket:3055.

comment:4 Changed 6 years ago by Mark Rowe <mrowe@…>

In 9faa032550c15cba038c5548cb7325edabd68f30:

Move source steps over to the CompositeStepMixin?.runRmdir now that it
uses the appropriate timeout.

This addresses problems similar to issue 3055 in other source control types.

Note: See TracTickets for help on using tickets.