Opened 4 years ago

Last modified 17 months ago

#3054 reopened defect

Shall not log the 404 errors

Reported by: Ben Owned by:
Priority: minor Milestone: 0.9.5
Version: master Keywords: web, simple
Cc:

Description (last modified by tardyp)

We are logging in main log the 404 errors, but the UI is on purpose generating 404 errors automatically to find out if the build is the last one.

We have http.log for loging 404s

-- original description:

For one, the error message is not very explicit.

It happens after a restart, or when builds are finished. there might be other places though.

Change History (13)

comment:1 Changed 4 years ago by dustin

  • Milestone changed from undecided to 0.9.0

Which logs? On the client side?

comment:2 Changed 4 years ago by sa2ajj

It's in master's twistd.log

Last edited 4 years ago by sa2ajj (previous) (diff)

comment:3 Changed 4 years ago by dustin

  • Keywords simple added

Ah, OK -- that's debugging output, so it could certainly be more verbose -- at least including the path and the endpoint instance.

comment:4 Changed 3 years ago by Ben

Recent improvements to the logging improved that error message:

2015-05-22 15:23:16+0200 [-] REST error: not found while getting from endpoint for 
	        /builds/n:buildid
	        /builders/n:builderid/builds/n:number
	     with arguments ResultSpec(**{'fields': None, 'limit': None, 'order': None, 'filters': [], 'offset': None}) and {'number': 334, 'builderid': 29}

comment:5 Changed 3 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

I think this is resolved, then..

comment:6 Changed 3 years ago by Ben

  • Resolution fixed deleted
  • Status changed from closed to reopened

That error messages clearly indicates that some component is accessing a wrong URI. I believe that's an error that needs to be fixed !

This might comes from the way we are detecting if 'next' build should be grayed or not. Relying on error conditions here is pretty weak !

comment:7 Changed 3 years ago by dustin

From a REST perspective, 404 is a perfectly reasonable way to represent that situation. Putting exceptions into the log for it is less good.

comment:8 Changed 2 years ago by tardyp

  • Description modified (diff)
  • Summary changed from 'REST error: not found' in the logs to Shall not log the 404 errors

comment:9 Changed 2 years ago by dustin

  • Milestone changed from 0.9.0 to 0.9.1

comment:10 Changed 20 months ago by tardyp

  • Milestone changed from 0.9.1 to 0.9.2

Ticket retargeted after milestone closed

comment:11 Changed 18 months ago by tardyp

  • Milestone changed from 0.9.2 to 0.9.3

Ticket retargeted after milestone closed

comment:12 Changed 17 months ago by tardyp

  • Milestone changed from 0.9.3 to 0.9.4

Ticket retargeted after milestone closed

comment:13 Changed 17 months ago by tardyp

  • Milestone changed from 0.9.4 to 0.9.5

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.