Opened 3 years ago

Last modified 3 years ago

#2974 assigned defect

reconfig forget to update my builder

Reported by: Ben Owned by: Ben
Priority: minor Milestone: undecided
Version: master Keywords: config
Cc:

Description

Trying to find an easy test case for #2951, I was playing with this configuration:

c['builders'].append(util.BuilderConfig(name="bug2951", slavename="example-slave", factory=util.BuildFactory([steps.ShellCommand(command=['echo', 'a'])])))#,steps.ShellCommand(command=['echo', 'b'])])))
c['schedulers'].append(schedulers.ForceScheduler(name="bug2951", builderNames=['bug2951']))

When commenting out (or adding) the second 'echo' step, and then running a reconfig, the modification are not taken into account ...

Change History (5)

comment:1 Changed 3 years ago by dustin

  • Owner set to dustin
  • Status changed from new to assigned

Let me see if I can reproduce this in a test case, at least.

comment:2 Changed 3 years ago by dustin

I added a test (https://github.com/buildbot/buildbot/pull/1359) but whether by test or by manual experimentation, I couldn't replicate this.

Well, I did replicate it, but it was PEBKAC: my script to run a master copies the config file into a temporary directory. I was editing the original, and not the copy, then SIGHUP'ing the master. That didn't work very well.

So, can you provide a more detailed repro recipe?

comment:3 Changed 3 years ago by Dustin J. Mitchell <dustin@…>

In 7f170f8e79cbff46f3b51cbee3b97ef9dad6e50e:

add a test for bug 2974

comment:4 Changed 3 years ago by Mikhail Sobolev <mss@…>

In 3e184775d74b5ca0d003e85702602e483c9b7696:

Merge pull request #1359 from djmitche/bug2974

add a test for bug 2974

Last edited 3 years ago by sa2ajj (previous) (diff)

comment:5 Changed 3 years ago by dustin

  • Owner changed from dustin to Ben
Note: See TracTickets for help on using tickets.