Opened 4 years ago

Last modified 19 months ago

#2961 accepted undecided

UI should use IDs to refer to schedulers

Reported by: Ben Owned by: tardyp
Priority: major Milestone: 0.9.5
Version: master Keywords: data
Cc:

Description

If a force scheduler has a space in its name, and we click on the button, nothing happens.

The breadcrumb on top becomes 'Builder.forcebuilder', and in the console, we get:

GET http://scaphoid.gb.intevation.de:8020/api/v2/forceschedulers/force%20scanner 404 (Not Found)

(Where 'force scanner' is the name of my scheduler)

Change History (12)

comment:1 Changed 4 years ago by Ben

Looking at the code, we're talking about:

/forceschedulers/i:schedulername

Which is nothing specific about this case, so I'd believe all endpoints have the same trouble ...

comment:2 Changed 4 years ago by Ben

  • Keywords data added; www removed

Indeed, all endpoints have the troubles.

For my information, the code is there: https://github.com/buildbot/buildbot/blob/master/master/buildbot/util/pathmatch.py, and the regex for identifier (^[a-zA-Z_-][.a-zA-Z0-9_-]*$) doesn't allow % neither space, so that we are urlencoded or not is not the bug, in both cases, the endpoint would not have been matched.

comment:3 Changed 4 years ago by dustin

We may need to set up "slugs" for schedulers, too. Within Buildbot, though, it would be better to refer to schedulers by id, rather than identifier.

comment:4 Changed 4 years ago by tardyp

  • Owner set to tardyp
  • Status changed from new to accepted

comment:5 Changed 4 years ago by dustin

#3189 adds slugs for schedulers, but using the id's from the UI is still a better idea.

comment:6 Changed 4 years ago by dustin

  • Version changed from 0.8.9 to master

comment:7 Changed 3 years ago by dustin

  • Summary changed from Force schedulers with space in their name break the www interface to UI should use IDs to refer to schedulers

comment:8 Changed 3 years ago by dustin

  • Milestone changed from 0.9.0 to 0.9.1

comment:9 Changed 22 months ago by tardyp

  • Milestone changed from 0.9.1 to 0.9.2

Ticket retargeted after milestone closed

comment:10 Changed 21 months ago by tardyp

  • Milestone changed from 0.9.2 to 0.9.3

Ticket retargeted after milestone closed

comment:11 Changed 20 months ago by tardyp

  • Milestone changed from 0.9.3 to 0.9.4

Ticket retargeted after milestone closed

comment:12 Changed 19 months ago by tardyp

  • Milestone changed from 0.9.4 to 0.9.5

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.