Changes between Version 2 and Version 3 of Ticket #2936, comment 17


Ignore:


Timestamp:
Dec 17, 2014, 11:12:08 PM (6 years ago)
Author:
zturner
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2936, comment 17

    v2 v3  
    1010in _dumbwin32proc.py
    1111
    12 In this case, "cmd" is "git".  There's a couple of important things to note about the first argument CreateProcess, from MSDN documentation (http://msdn.microsoft.com/en-us/library/windows/desktop/ms682425%28v=vs.85%29.aspx):
     12In this case, {{{cmd}}} is "git".  There's a couple of important things to note about the first argument {{{CreateProcess}}}, from [http://msdn.microsoft.com/en-us/library/windows/desktop/ms682425%28v=vs.85%29.aspx MSDN documentation]:
    1313
    1414{{{
     
    3434So as long as lpCommandLine contains the full command line including the executable name, we can specify NULL for the first arument.  This is already the case in _dumbwin32proc.py.  In the above invocation, "cmdline" is equal to "git init c:\test_master\gitpoller-workdir"
    3535
    36 So, in summary, the fix is to simply change that line to pass None for the first argument.
     36So, in summary, the fix is to simply change that line to pass {{{None}}} for the first argument.