Opened 3 years ago

Last modified 12 months ago

#2917 new defect

Dependent scheduler gets wrong sourcestamp if builds merged?

Reported by: dank Owned by:
Priority: minor Milestone: 0.9.+
Version: 0.7.12 Keywords: dependent
Cc:

Description

As I was considering using the Dependent scheduler, I ran across a problem which caused one team to stop using it, https://code.google.com/p/chromium/issues/detail?id=53226

It's an old bug, probably in 0.7.12, but since Dependent is outdated, maybe it hasn't changed.

The writeup is pretty good; it says in part

"8:16:46 Chromium Builder (dbg) finishes build 24647. A build is created which merges the 2 pending requests (or the master calls maybeStartBuild which checks to see if the 2 requests can be merged and does so). A new source stamp is now used for Chromium Builder (dbg) which starts build 24648. *The dependent scheduler is not updated.*

8:49:44 XP Tests (dbg)(1) starts build 28227 based on the original source stamp created at 7:47:01. This uses revision r59371, though the dependent scheduler was fired because Chromium Builder (dbg) finished build 24647 (for revision r59373). The extract build step tries to grab r59371, fails, grabs the unnumbered .zip. At this point, the console will give wrong results.

The key is that the tester's source stamp is not actually corrupted or incorrectly changed anywhere, it's just not updated to reflect its dependency's source stamp."

Change History (2)

comment:1 Changed 3 years ago by dustin

  • Keywords dependent added
  • Milestone changed from undecided to 0.9.+
  • Type changed from undecided to defect

Can you reproduce this with 0.8.9? Codebases (and a lot besides) have been added since 0.7.12, and I think those may cover this particular issue -- although I don't entirely understand the description of the issue. So a reproduction recipe would help.

Note: See TracTickets for help on using tickets.