Opened 6 years ago

Closed 5 years ago

#2893 closed defect (fixed)

Nightly 'branch' argument is required

Reported by: dustin Owned by: dustin
Priority: minor Milestone: 0.9.+
Version: Keywords:
Cc:

Description

This doesn't make a lot of sense, but it seems that Nightly requires the branch argument.

http://stackoverflow.com/questions/25455235/buildbot-figure-out-if-there-were-any-changes/25456904?noredirect=1#comment40227712_25456904

Nightly.gotChange filters by branch, and self.branch is passed to addBuildsetsForLatest if onlyIfChanged is false.

It *might* be enough to:

  • only filter by branch if it's not NoBranch
  • don't pass branch to addBuildsetsForLatest if it's NoBranch

But that's all a little more complex than I can think about at the moment. Am I missing some reason that branch is required?

Change History (3)

comment:1 Changed 6 years ago by dustin

  • Version 0.8.9 deleted

comment:2 Changed 5 years ago by dustin

  • Milestone changed from 0.9.0 to 0.9.+
  • Owner set to dustin
  • Status changed from new to assigned

comment:3 Changed 5 years ago by dustin

  • Resolution set to fixed
  • Status changed from assigned to closed

This was largely finished by delanne. I just fixed up the docs.

https://github.com/buildbot/buildbot/pull/1847

Note: See TracTickets for help on using tickets.