Ticket #286 (closed defect: fixed)
.buildbot/options not picking up username etc for sendchange
|Reported by:||gregb||Owned by:|
Have been setting up buildbot (am a new user, on win32, locally hosting master and slave), have successfully started master / slaves can connect / browse etc.
buildbot sendchange --master=localhost:9989 --username someuser
works, but setting the 'username' option in the .buildhost/options does not. My .buildhost/options:
master = 'somehost:9989' username = 'someuser'
Looking into this I found that runner.py loadOptions function does not return the localDict that was loaded from the file. Adding 'return localDict' to the end helps.
The next problem is that the suboptions have default values of None for the options like username etc. So code like
user = config.get('username', opts.get('username')) master = config.get('master', opts.get('master'))
in sendChange sets user to None even though opts now has a 'username' value. Code in other routines does stuff like
master = config.get('master') if not master: master = opts.get('master')
I haven't tried debugging further at this point.